This repository has been archived by the owner on Dec 11, 2022. It is now read-only.
modify args of logger so that it follows key/value pairs(Fixes #303 partially) #304
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes "Fixes #303 (Partially)".
As I said in #303, when an error occurs in
pkg/plugin.go
,err
object isn't expanded to%v
. So I can't see detail error.Example:
bigquery-grafana/pkg/plugin.go
Line 187 in 756780e
Logger in
github.com/grafana/grafana-plugin-sdk-go/backend/log
usesgo-hclog
(https://github.com/hashicorp/go-hclog). From README ingo-hclog
, args of logger should be specified as key/value pair.https://github.com/hashicorp/go-hclog#emit-an-info-level-message-with-2-keyvalue-pairs
So I have modified args and confirmed
err
is expanded.Would you check codes that I have modified? Thank you for looking my PR!