Skip to content

CSI-1655: changed to use TargetGroupBinding from ingress #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: features/csi-1655
Choose a base branch
from

Conversation

kdeng
Copy link

@kdeng kdeng commented Jun 19, 2025

No description provided.

EC2 Default User and others added 15 commits June 11, 2025 07:53
…cryption

Feature/storage class gp3 aws encryption
…fication

added retain policy to rbac to avoid timeout errors associated with cdk destroy
…fication

removed some complex code that's no longer used
… any user/role within account being able to role assume to eks admin. Replaced with IAM whitelisting, while maintaining similar UX. Output has changed a bit though.
…sh, also avoided duplicate read only account list which wasn't actually an issue, and verified duplicate tags are a non-issue.
@kdeng kdeng requested a review from neoakris June 19, 2025 11:54
@kdeng
Copy link
Author

kdeng commented Jun 19, 2025

@neoakris I just switched to use TargetGroupBinding CRD instead of ingress, and it seems to work as expected for both deploy and destroy.

@neoakris
Copy link
Collaborator

neoakris commented Jun 23, 2025

I merged integration into this to fix merge conflicts.
I'm currently deploying, will then destroy, and then will try to get this merged into integration today if things go smoothly. (changes & gameplan discussed over call, update me when ready for review again.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants