Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Division crashes when entering the menu since 1.3 #1149

Closed
pingubot opened this issue Aug 3, 2019 · 1 comment
Closed

The Division crashes when entering the menu since 1.3 #1149

pingubot opened this issue Aug 3, 2019 · 1 comment

Comments

@pingubot
Copy link
Contributor

pingubot commented Aug 3, 2019

The Division crashes when entering the menu with >= 1.2 , 1.2.3 works fine.
Bisecting shows the following commit is the issue:

commit 1cc531eaf8002cef3e9707cdc3398f45909e38d2
Author: Philip Rebohle <philip.rebohle@tu-dortmund.de>
Date:   Fri Jul 5 10:25:06 2019 +0200

    [d3d11] Return error when mapping an already mapped image
    
    Final Fantasy XIV does this. Should avoid some unnecessary work.

Reverting that commit lets the game enter the menu again.
@pingubot pingubot changed the title The Division crashes when enterin the menu since 1.3 The Division crashes when entering the menu since 1.3 Aug 3, 2019
doitsujin added a commit that referenced this issue Aug 3, 2019
@doitsujin
Revert "[d3d11] Return error when mapping an already mapped image"
140a2c1 
This reverts commit 1cc531e.

Even though an FFXIV apitrace clearly indicates that mapping an
already mapped subresource returns E_OUTOFMEMORY in that game,
this doesn't always seem to be correct behaviour.

Fixes #1148, #1149.
@doitsujin
Copy link
Owner

Fixed in the above commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@doitsujin @pingubot