Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GTA: San Andreas - The Definitive Edition crashes with HDR on. #4449

Closed
Hadrianneue opened this issue Nov 12, 2024 · 10 comments
Closed

GTA: San Andreas - The Definitive Edition crashes with HDR on. #4449

Hadrianneue opened this issue Nov 12, 2024 · 10 comments

Comments

@Hadrianneue
Copy link

Hadrianneue commented Nov 12, 2024

Game crashes with just the DXVK_HDR=1 with fatal error dialog message on startup, crashes with gamescope if using the --hdr-enabled option, by default it runs with DX11, forcing DX12 with %command% -dx12 actually gets in game without crashes, allows me to enabled HDR but it doesn't work, has no effect.

originally submitted on ValveSoftware/gamescope#1625

Software information

  • Desktop environment: KDE 6.2
  • Session type: wayland
  • Gamescope version: 3.15.9-21-g7dd1bcd9 (gcc 14.2.1)

System information

  • GPU: RX 6700 XT
  • Driver: mesa-git
  • Wine version: proton experimental bleeding-edge
  • DXVK version: dxvk-git

Log files

steam.log

@doitsujin
Copy link
Owner

doitsujin commented Nov 12, 2024

This is unfortunately normal for UE4 since their DX11 path only supports HDR through AGS or NVAPI for some reason and doesn't error-check a single thing, so if anything goes wrong there it just explodes. We have code to disable HDR for UE4 but it doesn't work here because the exe name doesn't seem to follow the usual *-Shipping.exe pattern.

TL;DR if you want to use HDR with any Unreal Engine game, you have to use D3D12, but we can add an app profile to avoid the crash.

@Blisto91
Copy link
Contributor

Blisto91 commented Nov 12, 2024

You can try to launch with PROTON_FORCE_NVAPI=1 %command% to see if that allows it to work in d3d11 mode. It not working in d3d12 mode i don't know but it could just be a game thing as dx12 might not be considered supported or tested by the devs.

Edit: To clarify. The reason the ags path doesn't work with these UE4 games is that it is statically linked which doesn't work in Proton/Wine.

@Hadrianneue
Copy link
Author

You can try to launch with PROTON_FORCE_NVAPI=1 %command% to see if that allows it to work in d3d11 mode. It not working in d3d12 mode i don't know but it could just be a game thing as dx12 might not be considered supported or tested by the devs.

Edit: To clarify. The reason the ags path doesn't work with these UE4 games is that it is statically linked which doesn't work in Proton/Wine.

that indeed works and is necessary on asseto corsa competizione, which is dx11

@Hadrianneue
Copy link
Author

This is unfortunately normal for UE4 since their DX11 path only supports HDR through AGS or NVAPI for some reason and doesn't error-check a single thing, so if anything goes wrong there it just explodes. We have code to disable HDR for UE4 but it doesn't work here because the exe name doesn't seem to follow the usual *-Shipping.exe pattern.

TL;DR if you want to use HDR with any Unreal Engine game, you have to use D3D12, but we can add an app profile to avoid the crash.

PROTON_FORCE_NVAPI=1 does prevent crashing even on dx11, either way HDR is simply not working, the toggle makes no difference... other UE4/5 games work just fine with HDR

Actually im going to check windows later today, not even sure if its working there

@qinlili23333
Copy link
Contributor

because the exe name doesn't seem to follow the usual *-Shipping.exe pattern

Maybe we should improve UE4 detecting method.
Current status is:

  • Some game doesn't follow Shipping.exe format (GTASA-DE in this issue, and Hi-Fi Rush on my device is Hi-Fi-RUSH.exe)
  • Some UE3 game also follow Shipping.exe format (MMH7Game-Win64-Shipping.exe for Might and Magic Heroes VII)
  • We hardcoded bool isUE4 = exeName.find("-Win64-Shipping") != std::string::npos; which won't allow 32-bit games been detected, but there are some 32-bit UE4 games (I made a list of them using PCGW query, although I didn't see any of them has HDR support currently)

I suggest to use \Content\Paks folder structure to detect UE4.

@Blisto91
Copy link
Contributor

@Hadrianneue Did you find out if HDR works on Windows?

@mirh
Copy link

mirh commented Nov 20, 2024

since their DX11 path only supports HDR through AGS or NVAPI for some reason

Shouldn't this be handled by/in dxvk-nvapi then?

@Blisto91
Copy link
Contributor

Blisto91 commented Nov 20, 2024

No as a user might not be using nvapi. Outside Proton as an example.

@Hadrianneue
Copy link
Author

@Hadrianneue Did you find out if HDR works on Windows?

sorry dude i somehow missed this notification, i tried today and HDR seems to not be working on windows at all, game only worked with DX11 on windows, dx12 crashes, but i'm almost certain that its broken.

@mirh
Copy link

mirh commented Nov 21, 2024

Dxvk isn't supposed to handle d3d12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants