Print VK_EXT_memory_budget stats on allocation failure #1112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an allocation fails right now DXVK will print out the following
statistics for each heap:
allocated - Memory allocated by DXVK in MB
used - Memory used by DXVK (from the chunk that it has allocated) in MB
available - Size of the heap in MB
This change re-works this logging to include values provided by the
VK_EXT_memory_budget extension, providing the following additional
information:
allocated (driver) - Memory allocated in MB as reported by the driver
- VK_EXT_memory_budget's `heapUsage`
available (driver) - Memory available for usage by the application as
reported by the driver
- VK_EXT_memory_budget's `heapBudget`
Restore logging to the behavior before the "[dxvk] Print memory_budget stats on allocation failure" commit, if VK_EXT_memory_budget support isn't advertised by the driver.
|
Let me know if you'd like me to |
doitsujin
added a commit
that referenced
this pull request
Jul 3, 2019
Based on PR #1112, but using a cleaner method to check support for the VK_EXT_memory_budget extension. Suggested-by: Liam Middlebrook <lmiddlebrook@nvidia.com>
|
Thanks; I added a cleaner way to check whether the DxvkDevice supports |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help with logging efforts for #1100 .