[d3d11] Fix device ref counting from queries. #1887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes AO Tennis 2 crash on exit.
misyltoad
reviewed
Jan 6, 2021
misyltoad
reviewed
Jan 6, 2021
misyltoad
approved these changes
Jan 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes AO Tennis 2 crash on exit.
The crash is due to DxvkGpuQueryAllocator::freeQuery is called after the DxvkGpuQueryAllocator has been already freed, which is probably due to missing reference counting from d3d11 query to d3d11 device (device gets destroyed while there are still queries created from it). The similar crash is reproducible on Windows with dxvk.