Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deviceUUID filter with DXVK_FILTER_DEVICE_UUID #2408

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
22 changes: 21 additions & 1 deletion src/dxvk/dxvk_device_filter.cpp
Original file line number Diff line number Diff line change
@@ -1,18 +1,29 @@
#include "dxvk_device_filter.h"

std::string convertUUID(const uint8_t uuid[VK_UUID_SIZE]) {
std::ostringstream stream;
for (unsigned int i = 0; i < VK_UUID_SIZE; i++) {
stream << static_cast<uint32_t>(uuid[i]);
}
return stream.str();
}

namespace dxvk {

DxvkDeviceFilter::DxvkDeviceFilter(
DxvkDeviceFilterFlags flags,
const DxvkOptions& options)
: m_flags(flags) {
m_matchDeviceName = env::getEnvVar("DXVK_FILTER_DEVICE_NAME");

m_matchDeviceUUID = env::getEnvVar("DXVK_FILTER_DEVICE_UUID");

if (m_matchDeviceName.empty())
m_matchDeviceName = options.deviceFilter;

if (!m_matchDeviceName.empty())
m_flags.set(DxvkDeviceFilterFlag::MatchDeviceName);
if (!m_matchDeviceUUID.empty())
m_flags.set(DxvkDeviceFilterFlag::MatchDeviceUUID);
}


Expand Down Expand Up @@ -44,5 +55,14 @@ namespace dxvk {

return true;
}

bool DxvkDeviceFilter::testCreatedAdapter(const DxvkDeviceInfo& deviceInfo) const {
if (m_flags.test(DxvkDeviceFilterFlag::MatchDeviceUUID)) {
if (convertUUID(deviceInfo.coreDeviceId.deviceUUID).find(m_matchDeviceUUID) == std::string::npos)
return false;
}

return true;
}

}
15 changes: 13 additions & 2 deletions src/dxvk/dxvk_device_filter.h
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ namespace dxvk {
*/
enum class DxvkDeviceFilterFlag {
MatchDeviceName = 0,
SkipCpuDevices = 1,
MatchDeviceUUID = 1,
SkipCpuDevices = 2,
};

using DxvkDeviceFilterFlags = Flags<DxvkDeviceFilterFlag>;
Expand Down Expand Up @@ -46,13 +47,23 @@ namespace dxvk {
*/
bool testAdapter(
const VkPhysicalDeviceProperties& properties) const;

/**
* \brief Tests a created adapter
*
* \param [in] properties Adapter properties
* \returns \c true if the test passes
*/
bool testCreatedAdapter(
const DxvkDeviceInfo& deviceInfo) const;

private:

DxvkDeviceFilterFlags m_flags;

std::string m_matchDeviceName;
std::string m_matchDeviceUUID;

};

}
}
6 changes: 4 additions & 2 deletions src/dxvk/dxvk_instance.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -263,9 +263,11 @@ namespace dxvk {
uint32_t numIGPU = 0;

for (uint32_t i = 0; i < numAdapters; i++) {
if (filter.testAdapter(deviceProperties[i])) {
if (filter.testAdapter(deviceProperties[i]))
result.push_back(new DxvkAdapter(m_vki, adapters[i]));

if (!filter.testCreatedAdapter(result.back()->devicePropertiesExt())) {
result.pop_back();
} else {
if (deviceProperties[i].deviceType == VK_PHYSICAL_DEVICE_TYPE_DISCRETE_GPU)
numDGPU += 1;
else if (deviceProperties[i].deviceType == VK_PHYSICAL_DEVICE_TYPE_INTEGRATED_GPU)
Expand Down
Loading