Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[utils] Hide Intel Gpu for Batman Arkham Knight #4152

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

FelixK15
Copy link
Contributor

@FelixK15 FelixK15 commented Jul 15, 2024

Without this fix, Batman Arkham Knight won't boot on Intel GPUs since the code explicitly checks for vendor id 0x10DE & 0x1002 and if the vendor id is different, the game won't boot.

@WinterSnowfall
Copy link
Contributor

Why not dxgi.hideIntelGpu = True then?

@FelixK15
Copy link
Contributor Author

FelixK15 commented Jul 16, 2024

If I read the code in https://github.com/doitsujin/dxvk/blob/master/src/dxgi/dxgi_adapter.cpp#L289 correctly, wouldn't that result in a vendorId of 0xDEAD? This would also fail for Batman Arkham Knight because it only whitelists vendoir Id 0x10DE & 0x1002.

Edit: Never mind, just read the code again and it seems like it'll then set the vendor id to 0x1002. I'll try the change locally and then update the PR.

@WinterSnowfall
Copy link
Contributor

WinterSnowfall commented Jul 16, 2024

If I read the code in https://github.com/doitsujin/dxvk/blob/master/src/dxgi/dxgi_adapter.cpp#L289 correctly, wouldn't that result in a vendorId of 0xDEAD?

You did not :).

      if (!options->hideAmdGpu) {
        // AMD RX 6700XT
        fallbackVendor = uint16_t(DxvkGpuVendor::Amd);
        fallbackDevice = 0x73df;
      }

It will default to AMD unless you use any of the other hide options.

@FelixK15
Copy link
Contributor Author

FelixK15 commented Jul 16, 2024

Changed to dxgi.hideIntelGpu = True as suggested

@FelixK15 FelixK15 changed the title [utils] Add custom vendor Id for Batman Arkham Knight [utils] Hide Intel Gpu for Batman Arkham Knight Jul 16, 2024
@doitsujin doitsujin merged commit 2a2d51e into doitsujin:master Jul 16, 2024
@FelixK15 FelixK15 deleted the BatmanAK_IntelFix branch July 16, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants