[d3d9] Optimize late buffer uploads with dirty bitmasks #4275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
K0bin
force-pushed
the
vbo-bitmask-opt
branch
4 times, most recently
from
0ed6075 to
df1f634
Compare
K0bin
force-pushed
the
vbo-bitmask-opt
branch
2 times, most recently
from
b08305b to
0ddfbf4
Compare
doitsujin
reviewed
Sep 22, 2024
| dynamicSysmemVBOs &= vbo == nullptr || (vbo->DoPerDrawUpload() || CanOnlySWVP()); | ||
| } | ||
| const uint32_t usedBuffersMask = (m_state.vertexDecl != nullptr ? m_state.vertexDecl->GetStreamMask() : ~0u) & m_activeVertexBuffers; | ||
| bool dynamicSysmemVBOs = usedBuffersMask == m_activeVertexBuffersToUploadPerDraw; |
There was a problem hiding this comment.
What's the intention here with the ==, what if usedBuffersMask is a superset of m_activeVertexBuffersToUploadPerDraw?
There was a problem hiding this comment.
The problem is that we change the BaseVertexIndex so it can only work if we copy the data for all bound vertex buffers.
=> all bound buffers that get actually used by the draw need to be part of the bitmask.
If usedBuffersMask is a superset, we don't copy the data this specific draw needs into a separate buffer and instead bind the buffer directly.
K0bin
force-pushed
the
vbo-bitmask-opt
branch
from
0ddfbf4 to
59a7f70
Compare
... similar to what we're doing for textures.
The same texture could be bound to multiple slots and if the shader doesn't use the lower index texture, we'd never end up uploading it.
K0bin
force-pushed
the
vbo-bitmask-opt
branch
from
59a7f70 to
1767d88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #4274
Optimizes late buffer uploads (managed or per-draw) similar to how we're doing it for textures.
This avoids having to iterate over all 16 vertex buffers multiple times for every draw.