D3D9: Handle binding mismatching texture types #4513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
K0bin
changed the title
K0bin
changed the title
|
Fun game bug in Alpha Protocol:
|
K0bin
force-pushed
the
d3d9-texture-type-mismatch
branch
3 times, most recently
from
0d8fae0 to
e664f96
Compare
|
I also tried it with Star Wars Force Unleashed 2 with forceSamplerTypeSpecConst disabled and didn't see any issues. But at the same time I don't remember how difficult it was to hit the bug that made me enable that option for the game in the first place so idk, I think I'll just keep the option for it for now. |
K0bin
force-pushed
the
d3d9-texture-type-mismatch
branch
from
e664f96 to
c5b2384
Compare
|
Tested a few games without issue |
K0bin
force-pushed
the
d3d9-texture-type-mismatch
branch
from
c5b2384 to
313a399
Compare
doitsujin
reviewed
Dec 17, 2024
doitsujin
reviewed
Dec 17, 2024
doitsujin
reviewed
Dec 17, 2024
K0bin
force-pushed
the
d3d9-texture-type-mismatch
branch
from
313a399 to
7ae2304
Compare
The texture type check makes this redundant.
K0bin
force-pushed
the
d3d9-texture-type-mismatch
branch
from
7ae2304 to
98e74eb
Compare
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4387
Alpha Protocol binds a cube texture to a slot which is declared as a 2d texture in the shader. Binding a mismatching texture type leads yields (0,0,0,0) (yes, alpha 0, unlike binding NULL) on native D3D9. See the table inside the issue.
I also checked that this is checked at draw time, not at the time of the SetTexture call. So binding a shader with a correct texture type afterwards results in correct rendering and the other way around as well.
Because if there's one thing the D3D9 frontend needed, it is more bit field tracking... :)