Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[util] Cleanup some deviceLossOnFocusLoss configs #4655

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

Blisto91
Copy link
Contributor

@Blisto91 Blisto91 commented Jan 29, 2025

A bunch of alt-tab related issues are gone on current master which allows a small builtin config cleanup.
This has been tested on a RTX 4080 in KDE Wayland, KDE X11 and Windows.

Delta Force, The Sims 3, Guild Wars 1 and Splinter Cell Conviction work out of the box since #4609 so the configs aren't needed.
Rise of Nations is fine since the 2.4.1 release without the config.

Closes #4082

These game work fine out of the box now
missed
@doitsujin
Copy link
Owner

Do we understand why these are no longer needed?

@Blisto91
Copy link
Contributor Author

Blisto91 commented Jan 30, 2025

For the 4 games mentioned first and in #4082 then, the ones that wanted to work with the commit, i reversed bisected to start working on their own since 43838d3
The problem mentioned in the linked issue are old regressions from a previous time when the swapchain code was touched.
Though i can't give a technical reason as to why.

Rise of Nations i have not bisected which specific commit that fixed the issue in 2.4.1

Edit: No dev have taken a deeper look if that is what you meant.

@doitsujin
Copy link
Owner

The strange part here is that the swapchain backend code really should be transparent to the app, so this is a little bit worrying.

Will merge for now, but probably good to keep an eye on things.

@doitsujin doitsujin merged commit 8776cf2 into doitsujin:master Jan 30, 2025
4 checks passed
@turbedi
Copy link

turbedi commented Jan 30, 2025

Aren't the comments for Splinter Cell Conviction and Delta Force outdated now? They still mention the black screen on Alt-Tab

@Blisto91
Copy link
Contributor Author

Yes. Derp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[d3d9, regressions] Alt-tab issues in fullscreen at non native resolutions
3 participants