Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: use UMD externals #133

Merged
merged 1 commit into from
Aug 17, 2018
Merged

Fix: use UMD externals #133

merged 1 commit into from
Aug 17, 2018

Conversation

mwistrand
Copy link
Contributor

Since AMD externals cannot be used with UMD modules, update the
externals config setting to use a UMD object instead of a string that
declares the external's module type.

Since AMD externals cannot be used with UMD modules, update the
externals config setting to use a UMD object instead of a string that
declares the external's module type.
@codecov
Copy link

codecov bot commented Aug 16, 2018

Codecov Report

Merging #133 into master will increase coverage by 0.12%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #133      +/-   ##
==========================================
+ Coverage   57.42%   57.55%   +0.12%     
==========================================
  Files           8        8              
  Lines         451      450       -1     
  Branches      101      101              
==========================================
  Hits          259      259              
+ Misses        192      191       -1
Impacted Files Coverage Δ
src/base.config.ts 25.89% <0%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2c50f5...163eb19. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants