Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add single bundle mode for the build output #145

Merged
merged 2 commits into from
Aug 24, 2018
Merged

Conversation

agubler
Copy link
Member

@agubler agubler commented Aug 23, 2018

Adds an options to produce a single "main" bundle in the build output.

@agubler agubler requested a review from mwistrand August 23, 2018 13:48
Copy link
Contributor

@mwistrand mwistrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The phrase "single file" is not clear. Perhaps something like "single bundle" would be better?

@codecov
Copy link

codecov bot commented Aug 24, 2018

Codecov Report

Merging #145 into master will decrease coverage by 1.16%.
The diff coverage is 9.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #145      +/-   ##
==========================================
- Coverage   58.05%   56.89%   -1.17%     
==========================================
  Files           8        8              
  Lines         453      464      +11     
  Branches      102      112      +10     
==========================================
+ Hits          263      264       +1     
- Misses        190      200      +10
Impacted Files Coverage Δ
src/dev.config.ts 24.52% <0%> (-2.01%) ⬇️
src/dist.config.ts 32.2% <0%> (-2.35%) ⬇️
src/base.config.ts 28.2% <0%> (-0.5%) ⬇️
src/main.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcb4de1...611d58d. Read the comment docs.

@agubler agubler merged commit 3213b6b into dojo:master Aug 24, 2018
agubler added a commit to agubler/cli-build-app that referenced this pull request Aug 24, 2018
* Add single file mode for the build output

* single file to single bundle
@agubler agubler changed the title Add single file mode for the build output Add single bundle mode for the build output Aug 24, 2018
agubler added a commit that referenced this pull request Aug 24, 2018
* Add single file mode for the build output

* single file to single bundle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants