Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: do not rewrite sw file with history fallback #212

Merged
merged 2 commits into from
Nov 21, 2018

Conversation

mwistrand
Copy link
Contributor

Type: bug

The following has been addressed in the PR:

  • There is a related issue
  • All code has been formatted with prettier
  • Unit or Functional tests are included in the PR

Description:

Update the history fallback rewriter to ignore both files without a referrer (direct access in the browser) and service worker files that are their own referrer.

Resolves #211

Update the history fallback rewriter to ignore both files without a
referrer (direct access in the browser) and service worker files that
are their own referrer.
@mwistrand mwistrand requested a review from agubler November 16, 2018 19:01
@codecov
Copy link

codecov bot commented Nov 20, 2018

Codecov Report

Merging #212 into master will increase coverage by 1.68%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #212      +/-   ##
==========================================
+ Coverage   52.14%   53.83%   +1.68%     
==========================================
  Files          10       10              
  Lines         583      587       +4     
  Branches      142      143       +1     
==========================================
+ Hits          304      316      +12     
+ Misses        279      271       -8
Impacted Files Coverage Δ
src/main.ts 91.27% <100%> (+4.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a389b2...b13508b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants