Watch other resources (#226) #227
Conversation
|
Bradley Maier seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
Codecov Report
@@ Coverage Diff @@
## master #227 +/- ##
=========================================
- Coverage 52.68% 52.5% -0.19%
=========================================
Files 10 10
Lines 596 600 +4
Branches 144 146 +2
=========================================
+ Hits 314 315 +1
- Misses 282 285 +3
Continue to review full report at Codecov.
|
src/base.config.ts
Outdated
| }), | ||
| watch && | ||
| new ExtraWatchWebpackPlugin({ | ||
| files: ['!(output|.*)/**'] |
There was a problem hiding this comment.
does this ignore node_modules by default?
There was a problem hiding this comment.
That was the behavior I observed in testing, but it's not explicitly documented as such so I've added it here.
package.json
Outdated
| @@ -114,6 +114,7 @@ | |||
| "eventsource-polyfill": "0.9.6", | |||
| "express": "4.16.2", | |||
| "express-static-gzip": "1.1.3", | |||
| "extra-watch-webpack-plugin": "^1.0.3", | |||
src/base.config.ts
Outdated
| @@ -417,7 +423,7 @@ export default function webpackConfigFactory(args: any): webpack.Configuration { | |||
| } | |||
| }, | |||
| { | |||
| test: /\.(css|js)$/, | |||
| test: /\.(css|js)/, | |||
There was a problem hiding this comment.
was this meant to change?
There was a problem hiding this comment.
Nope, sorry about that. I've reverted that change.
Use the extra-watch-webpack-plugin to watch all files not in dot folders, output, or node_modules.
maier49
force-pushed
the
226-watch-resources
branch
from
6d71db3 to
3abe150
Compare
Use the extra-watch-webpack-plugin to watch all files not in
dot folders, output, or node_modules.
Type: feature
The following has been addressed in the PR:
prettierDescription:
Resolves #226