Add fetch shim to the BootstrapPlugin options
#233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-gadd
reviewed
Jan 17, 2019
| }, | ||
| { | ||
| module: '@dojo/framework/shim/fetch', | ||
| has: 'build-fetch' |
There was a problem hiding this comment.
would be good in the future if these were all consistent to be whatever prefixed flag we need.
Codecov Report
@@ Coverage Diff @@
## master #233 +/- ##
=======================================
Coverage 52.97% 52.97%
=======================================
Files 10 10
Lines 606 606
Branches 148 148
=======================================
Hits 321 321
Misses 285 285
Continue to review full report at Codecov.
|
matt-gadd
approved these changes
Jan 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
prettierDescription:
Adds
@dojo/framework/shim/fetchto theBootstrapPluginconfiguration options.