Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the entry name for externals based on single bundle config #237

Merged
merged 1 commit into from
Jan 24, 2019

Conversation

agubler
Copy link
Member

@agubler agubler commented Jan 24, 2019

Type: bug

The following has been addressed in the PR:

  • There is a related issue
  • All code has been formatted with prettier
  • Unit or Functional tests are included in the PR

Description:

Switch the entry name for externals based on the type of build.

@codecov
Copy link

codecov bot commented Jan 24, 2019

Codecov Report

Merging #237 into master will increase coverage by 3.99%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #237      +/-   ##
=========================================
+ Coverage    52.6%   56.6%   +3.99%     
=========================================
  Files          10      10              
  Lines         614     689      +75     
  Branches      154     178      +24     
=========================================
+ Hits          323     390      +67     
- Misses        291     299       +8
Impacted Files Coverage Δ
src/base.config.ts 22.72% <0%> (-0.13%) ⬇️
src/main.ts 90.57% <0%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3282b45...0d8573a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants