Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only create DTS for css modules #354

Merged
merged 2 commits into from
Dec 18, 2019

Conversation

agubler
Copy link
Member

@agubler agubler commented Dec 17, 2019

Type: bug

The following has been addressed in the PR:

  • There is a related issue
  • All code has been formatted with prettier
  • Unit or Functional tests are included in the PR
  • schema.json has been updated appropriately

Description:

Ensure that definition files are not created imported standard css from the src directory. For example when importing variables.css into a css module this should be filtered out.

@codecov
Copy link

codecov bot commented Dec 17, 2019

Codecov Report

Merging #354 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #354   +/-   ##
=======================================
  Coverage   48.62%   48.62%           
=======================================
  Files          10       10           
  Lines         689      689           
  Branches      193      193           
=======================================
  Hits          335      335           
  Misses        354      354
Impacted Files Coverage Δ
src/base.config.ts 19.65% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 394f8c0...c62139d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants