Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logger support for multiple compilations #357

Merged
merged 1 commit into from
Dec 31, 2019

Conversation

matt-gadd
Copy link
Contributor

Type: bug

The following has been addressed in the PR:

  • There is a related issue
  • All code has been formatted with prettier
  • Unit or Functional tests are included in the PR
  • schema.json has been updated appopriately

Description:
The logger currently breaks when used with multiple compilations. This fixes it so the first compilation is deemed the main compilation (used for output path etc), but chunks are still reported from all compilations.

@codecov
Copy link

codecov bot commented Dec 31, 2019

Codecov Report

Merging #357 into master will increase coverage by 0.15%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #357      +/-   ##
==========================================
+ Coverage   48.62%   48.77%   +0.15%     
==========================================
  Files          10       10              
  Lines         689      693       +4     
  Branches      193      196       +3     
==========================================
+ Hits          335      338       +3     
- Misses        354      355       +1
Impacted Files Coverage Δ
src/logger.ts 96.36% <88.88%> (-1.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b973d4...3e38eeb. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants