-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display BTR logging in console output #393
base: master
Are you sure you want to change the base?
Conversation
For a project like |
@maier49 One of the key focuses in 8 is to improve the cli output in terms of noise, and this looks very noisy. The main issue with this in my opinion is that I don't think it's really important for us to be outputting every page to the terminal (we can write this to an additional manifest file or similar). What we want to show is that we haven't hung during build time render. Would it be possible for us to have some animated icon and use a singe line in the output to show the page it is currently rendering? |
@matt-gadd I've update the POC to an approach where we modify the existing spinner with additional information about the current BTR path. ora does not support multiple spinners and the libraries with multiple spinner support I've seen have awkward APIs to work with for what we're doing. I'm currently trying to resolve an issue where for some specific paths the output from the spinner is repeatedly rendered to the console and then I think this will be a workable solution. |
Ok that issue has been fixed by updating ora, this is now working pending the changes in dojo/webpack-contrib#264 |
bbc8d10
to
bef59ed
Compare
Type: feature
The following has been addressed in the PR:
prettier
Description:
Adds logging of BTR info to build output:
Related to #390