Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display BTR logging in console output #393

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

maier49
Copy link
Contributor

@maier49 maier49 commented Apr 29, 2020

Type: feature

The following has been addressed in the PR:

  • There is a related issue
  • All code has been formatted with prettier
  • Unit or Functional tests are included in the PR
  • schema.json has been updated appopriately

Description:
Adds logging of BTR info to build output:
image

Related to #390

@maier49
Copy link
Contributor Author

maier49 commented Apr 29, 2020

For a project like site this generates over 100 lines of output for each the "visited" and "discovered" sections. It would probably make sense to limit this output to some specific number of pages.

@matt-gadd
Copy link
Contributor

@maier49 One of the key focuses in 8 is to improve the cli output in terms of noise, and this looks very noisy. The main issue with this in my opinion is that I don't think it's really important for us to be outputting every page to the terminal (we can write this to an additional manifest file or similar). What we want to show is that we haven't hung during build time render. Would it be possible for us to have some animated icon and use a singe line in the output to show the page it is currently rendering?

@maier49
Copy link
Contributor Author

maier49 commented Jul 2, 2020

@matt-gadd I've update the POC to an approach where we modify the existing spinner with additional information about the current BTR path. ora does not support multiple spinners and the libraries with multiple spinner support I've seen have awkward APIs to work with for what we're doing.

I'm currently trying to resolve an issue where for some specific paths the output from the spinner is repeatedly rendered to the console and then I think this will be a workable solution.

image

@maier49
Copy link
Contributor Author

maier49 commented Jul 2, 2020

Ok that issue has been fixed by updating ora, this is now working pending the changes in dojo/webpack-contrib#264

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants