Adding Electron Support #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rorticus
commented
Sep 4, 2020
| return compiler; | ||
| // for some reason the MultiCompiler type doesn't include hooks, even though they are clearly defined on the | ||
| // object coming back. | ||
| interface MultiCompilerWithHooks extends webpack.MultiCompiler { |
There was a problem hiding this comment.
Is there a better way to do this?
rorticus
commented
Sep 4, 2020
| const onDemandBtr = new OnDemandBtr({ | ||
| buildTimeRenderOptions: btrOptions, | ||
| scope: libraryName, | ||
| base, | ||
| compiler, | ||
| entries: config.entry ? Object.keys(config.entry) : [], | ||
| compiler: compiler.compilers[0], |
There was a problem hiding this comment.
No need to pass in electron compiler to BTR. Realistically, probably no reason to pass anything to BTR in this case...
rorticus
commented
Sep 4, 2020
src/main.ts
Outdated
| } | ||
|
|
||
| if (args.target === 'electron') { | ||
| args.base = `.${args.base}`; |
There was a problem hiding this comment.
If we're using electron, the base path can't be absolute and must be relative.
rorticus
commented
Sep 4, 2020
| @@ -119,6 +119,7 @@ | |||
| "css-loader": "1.0.1", | |||
| "css-url-relative-plugin": "1.0.0", | |||
| "cssnano": "4.1.7", | |||
| "electron": "10.1.1", | |||
There was a problem hiding this comment.
Adding electron as a dep here so you dont need to install it separately on every app. In the future, we'll look into how to conditionally install deps like puppetteer and electron.
rorticus
commented
Sep 4, 2020
| @@ -24,7 +24,7 @@ function webpackConfig(args: any): webpack.Configuration { | |||
| const experimental = args.experimental || {}; | |||
| const isExperimentalSpeed = !!experimental.speed; | |||
| const singleBundle = args.singleBundle || isExperimentalSpeed; | |||
| const base = args.base || '/'; | |||
| const base = args.target === 'electron' ? './' : args.base || '/'; | |||
There was a problem hiding this comment.
Electron target does not support a base URL
rorticus
commented
Sep 4, 2020
| @@ -33,7 +33,7 @@ All rights reserved | |||
|
|
|||
| function webpackConfig(args: any): webpack.Configuration { | |||
| const basePath = process.cwd(); | |||
| const base = args.base || '/'; | |||
| const base = args.target === 'electron' ? './' : args.base || '/'; | |||
There was a problem hiding this comment.
Electron target does not support a base URL
matt-gadd
approved these changes
Sep 9, 2020
This was referenced Apr 13, 2021
This was referenced Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
prettierDescription:
Adding Electron target. This is largely based on https://github.com/matt-gadd/cli-build-app/tree/electron-support.
Resolves #356