Use registry transformer #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #79 +/- ##
==========================================
- Coverage 68.84% 67.68% -1.17%
==========================================
Files 8 8
Lines 321 328 +7
Branches 55 57 +2
==========================================
+ Hits 221 222 +1
- Misses 95 101 +6
Partials 5 5
Continue to review full report at Codecov.
|
matt-gadd
reviewed
Mar 23, 2018
src/base.config.ts
Outdated
| onlyCompileBundledFiles: true, | ||
| instance: 'dojo', | ||
| getCustomTransformers: () => ({ | ||
| before: [registryTransformer(basePath, lazyModules)] |
There was a problem hiding this comment.
might be nice to only add this if we have lazyModules? not sure of the performance costs (we do not exit early from the transformer)
There was a problem hiding this comment.
Ah yeah that's a good suggestion.
matt-gadd
approved these changes
Mar 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
Description:
Implement the registry transformer, such that the widget modules specified in bundles entry of the dojorc will automatically be added to the registry at build time. This enables configuration driven code splitting for applications.