Dont end the process if we're serving #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #84 +/- ##
=======================================
Coverage 68.07% 68.07%
=======================================
Files 8 8
Lines 332 332
Branches 58 59 +1
=======================================
Hits 226 226
Misses 101 101
Partials 5 5
Continue to review full report at Codecov.
|
rorticus
approved these changes
Mar 29, 2018
dylans
approved these changes
Mar 29, 2018
|
I suspected that! We really should fix the BTR / need to process exit 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #82
So I checked with Rory, the description wasn't quite right. It does work for
dojo build -w -s, but not fordojo build -s. The reason seems to be that whendojo build -sis run without -w, it runs thebuildfunction, which callsprocess.exit(0). As it turns out the server stops running when the process ends.