Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "remove variables support (#30)" #33

Conversation

agubler
Copy link
Member

@agubler agubler commented Mar 22, 2020

This reverts commit b742419.

Type: feature

The following has been addressed in the PR:

  • There is a related issue
  • All code has been formatted with prettier
  • Unit or Functional tests are included in the PR

Description:

Reverts the changes to dealing with variables for the time being as are not ready for it. Waiting on supporting changes from dojo/framework.

@codecov
Copy link

codecov bot commented Mar 22, 2020

Codecov Report

Merging #33 into revert-removing-variables-support will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@                       Coverage Diff                       @@
##           revert-removing-variables-support   #33   +/-   ##
===============================================================
  Coverage                                  0%    0%           
===============================================================
  Files                                      5     5           
  Lines                                    157   159    +2     
  Branches                                  20    20           
===============================================================
- Misses                                   157   159    +2
Impacted Files Coverage Δ
src/webpack.config.ts 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b742419...6460879. Read the comment docs.

@agubler agubler merged commit 7cfaf47 into dojo:revert-removing-variables-support Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants