Updates for 3.0.0 #149
Merged
Updates for 3.0.0 #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanforbes
force-pushed
the
3.0.0
branch
4 times, most recently
from
75a22b3 to
35a077a
Compare
devpaul
previously requested changes
Jul 21, 2018
package.json
Outdated
| "precommit": "lint-staged", | ||
| "prettier": "prettier --write 'src/**/*.ts' 'tests/**/*.ts'", | ||
| "test": "grunt test" | ||
| "test": "npm run build && intern", |
There was a problem hiding this comment.
We should add prettier -l {src,tests}/**/*.ts to test in order to fail the build if files don't comply. It used to be possible to not run precommit if the user already had a git precommit script. Don't know if this has been fixed in husky.
tsconfig.json
Outdated
| "outDir": "_build/", | ||
| "removeComments": false, | ||
| "sourceMap": true, | ||
| "strict": true, | ||
| "target": "es2016", |
There was a problem hiding this comment.
Node 6 doesn't support es2016. It has decent support for es2015.
agubler
approved these changes
Jul 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
prettieras per the readme code style guidelinesDescription:
Resolves #148