This repository has been archived by the owner on Jul 30, 2018. It is now read-only.
Adding base64 encoding from web-editor and removed old encoding #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #339 +/- ##
==========================================
- Coverage 94.14% 93.98% -0.16%
==========================================
Files 40 40
Lines 2202 2063 -139
Branches 408 380 -28
==========================================
- Hits 2073 1939 -134
+ Misses 51 50 -1
+ Partials 78 74 -4
Continue to review full report at Codecov.
|
kitsonk
approved these changes
May 26, 2017
mwistrand
reviewed
May 26, 2017
| return decodeURIComponent(Array.prototype.map.call(atob(encodedString), (char: string) => '%' + ('00' + char.charCodeAt(0).toString(16)).slice(-2)).join('')); | ||
| } : function (encodedString: string): string { | ||
| return new Buffer(encodedString.toString(), 'base64').toString('utf8'); | ||
| }; |
There was a problem hiding this comment.
Essentially we are assuming that all supported browsers support btob/atob, since the alternative is the Node-specific Buffer?
There was a problem hiding this comment.
@mwistrand yeah, and I think we are good on that account, https://caniuse.com/#search=atob . Supported back to IE 10.
mwistrand
approved these changes
Jun 16, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: bug / feature
The following has been addressed in the PR:
Description:
Removing old
encoding.tsand replaced it with the base64 methods fromweb-editor. It doesn't look like the code fromencoding.tswas being used, so I think we can just ditch it.Resolves #299