This repository has been archived by the owner on Jul 30, 2018. It is now read-only.
Using importHelpers instead of noEmitHelpers #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanforbes
approved these changes
Nov 13, 2017
bryanforbes
suggested changes
Nov 13, 2017
There was a problem hiding this comment.
Can you go through and make sure that where we're using for...of that it's not on arrays? Or, if it's on an array, we treat them differently because of microsoft/TypeScript#19933 .
|
@bryanforbes I replaced the array-only usages of |
bryanforbes
reviewed
Nov 14, 2017
src/lang.ts
Outdated
| if (source === null || source === undefined) { | ||
| continue; | ||
| } | ||
| for (let key in source) { | ||
| if (inherited || hasOwnProperty.call(source, key)) { | ||
| let value: any = source[key]; | ||
| let value: any = source[ key ]; |
There was a problem hiding this comment.
Why are you adding spaces around key?
|
@bryanforbes Webstorm was overzealous. I've put back (most) of the style changes. I left ones alone that were fixing previous style errors because of reasons. |
bryanforbes
suggested changes
Nov 14, 2017
| } | ||
|
|
||
| return processedModules; | ||
| } else if (isIterable(modules)) { |
There was a problem hiding this comment.
Should the else if be on a new line?
bryanforbes
approved these changes
Nov 14, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
importHelpersinstead ofnoEmitHelpers. Helpers will be provided bytslibbut augmented by@dojo/shim/main.