Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tutorial feedback - Routing #283

Closed
umaar opened this issue Oct 20, 2017 · 0 comments
Closed

Tutorial feedback - Routing #283

umaar opened this issue Oct 20, 2017 · 0 comments
Milestone
2017.10

Comments

@umaar
Copy link
Member

umaar commented Oct 20, 2017

Link: https://dojo.io/tutorials/1030_routing/#2

Step 2: “Add the follow code to BannerOutlet.ts.”

“Follow” -> “following”
umaar added a commit to umaar/dojo.io that referenced this issue Oct 23, 2017
@umaar
dojo#245 Feedback 1
b77492d 
dojo#244 Feedback 1
dojo#270 Feedback 1
dojo#258 Feedback 1
dojo#251 Feedback 3
dojo#251 Feedback 4
dojo#250 Feedback 2
dojo#295 Feedback 1
dojo#295 Feedback 5
dojo#294 Feedback 3
dojo#294 Feedback 9
dojo#294 Feedback 12
dojo#294 Feedback 13
dojo#293 Feedback 1
dojo#293 Feedback 2
dojo#293 Feedback 14
dojo#293 Feedback 15
dojo#291 Feedback 1
dojo#291 Feedback 2
dojo#291 Feedback 3
dojo#291 Feedback 5
dojo#291 Feedback 6
dojo#291 Feedback 8
dojo#291 Feedback 16
dojo#289 Feedback 6

Resolves dojo#273
Resolves dojo#274
Resolves dojo#282
Resolves dojo#283
Resolves dojo#284
Resolves dojo#286
Resolves dojo#287
Resolves dojo#242
Resolves dojo#241
Resolves dojo#239
Resolves dojo#238
Resolves dojo#234
Resolves dojo#232
Resolves dojo#231
Resolves dojo#227
Resolves dojo#271
Resolves dojo#268
@umaar umaar mentioned this issue Oct 23, 2017
Merged
umaar added a commit that referenced this issue Oct 23, 2017
@umaar
A collection of tutorial text fixes (#297)
2e6b445 
* #245 Feedback 1
#244 Feedback 1
#270 Feedback 1
#258 Feedback 1
#251 Feedback 3
#251 Feedback 4
#250 Feedback 2
#295 Feedback 1
#295 Feedback 5
#294 Feedback 3
#294 Feedback 9
#294 Feedback 12
#294 Feedback 13
#293 Feedback 1
#293 Feedback 2
#293 Feedback 14
#293 Feedback 15
#291 Feedback 1
#291 Feedback 2
#291 Feedback 3
#291 Feedback 5
#291 Feedback 6
#291 Feedback 8
#291 Feedback 16
#289 Feedback 6

Resolves #273
Resolves #274
Resolves #282
Resolves #283
Resolves #284
Resolves #286
Resolves #287
Resolves #242
Resolves #241
Resolves #239
Resolves #238
Resolves #234
Resolves #232
Resolves #231
Resolves #227
Resolves #271
Resolves #268

* Fix instruction text in tutorial
edhager pushed a commit to edhager/dojo.io that referenced this issue Oct 26, 2017
@umaar @edhager
A collection of tutorial text fixes (dojo#297)
a987f3e 
* dojo#245 Feedback 1
dojo#244 Feedback 1
dojo#270 Feedback 1
dojo#258 Feedback 1
dojo#251 Feedback 3
dojo#251 Feedback 4
dojo#250 Feedback 2
dojo#295 Feedback 1
dojo#295 Feedback 5
dojo#294 Feedback 3
dojo#294 Feedback 9
dojo#294 Feedback 12
dojo#294 Feedback 13
dojo#293 Feedback 1
dojo#293 Feedback 2
dojo#293 Feedback 14
dojo#293 Feedback 15
dojo#291 Feedback 1
dojo#291 Feedback 2
dojo#291 Feedback 3
dojo#291 Feedback 5
dojo#291 Feedback 6
dojo#291 Feedback 8
dojo#291 Feedback 16
dojo#289 Feedback 6

Resolves dojo#273
Resolves dojo#274
Resolves dojo#282
Resolves dojo#283
Resolves dojo#284
Resolves dojo#286
Resolves dojo#287
Resolves dojo#242
Resolves dojo#241
Resolves dojo#239
Resolves dojo#238
Resolves dojo#234
Resolves dojo#232
Resolves dojo#231
Resolves dojo#227
Resolves dojo#271
Resolves dojo#268

* Fix instruction text in tutorial
edhager pushed a commit to edhager/dojo.io that referenced this issue Oct 26, 2017
@umaar @edhager
A collection of tutorial text fixes (dojo#297)
e007024 
* dojo#245 Feedback 1
dojo#244 Feedback 1
dojo#270 Feedback 1
dojo#258 Feedback 1
dojo#251 Feedback 3
dojo#251 Feedback 4
dojo#250 Feedback 2
dojo#295 Feedback 1
dojo#295 Feedback 5
dojo#294 Feedback 3
dojo#294 Feedback 9
dojo#294 Feedback 12
dojo#294 Feedback 13
dojo#293 Feedback 1
dojo#293 Feedback 2
dojo#293 Feedback 14
dojo#293 Feedback 15
dojo#291 Feedback 1
dojo#291 Feedback 2
dojo#291 Feedback 3
dojo#291 Feedback 5
dojo#291 Feedback 6
dojo#291 Feedback 8
dojo#291 Feedback 16
dojo#289 Feedback 6

Resolves dojo#273
Resolves dojo#274
Resolves dojo#282
Resolves dojo#283
Resolves dojo#284
Resolves dojo#286
Resolves dojo#287
Resolves dojo#242
Resolves dojo#241
Resolves dojo#239
Resolves dojo#238
Resolves dojo#234
Resolves dojo#232
Resolves dojo#231
Resolves dojo#227
Resolves dojo#271
Resolves dojo#268

* Fix instruction text in tutorial
@dylans dylans added this to the 2017.10 milestone Oct 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2017.10
Development

No branches or pull requests
2 participants
@dylans @umaar