Fix Keyboard and DnD incompatibility (#1067) #1445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`dgrid/extensions/DnD` uses `dojo/dnd/Source` which registers an event handler using `on(node, touch.press)`. `touch.press` evaluates to `'pointerdown'` in browsers that support pointer events, and when the `'pointerdown'` listener is registered the `'mousedown'` listener is never called. This change causes Keyboard to use `touch.press` when DnD is being used. It also exposes a new configuration property, `mouseDownEventType`, which enables developers to further customize this behavior.
edhager
approved these changes
Nov 11, 2019
This was referenced Jan 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dgrid/extensions/DnDusesdojo/dnd/Sourcewhich registers an event handlerusing
on(node, touch.press).touch.pressevaluates to'pointerdown'inbrowsers that support pointer events, and when the
'pointerdown'listener isregistered the
'mousedown'listener is never called.This change causes Keyboard to use
touch.presswhen DnD is being used. It alsoexposes a new configuration property,
mouseDownEventType, which enablesdevelopers to further customize this behavior.