-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build issue for dstore/extensions/RqlQuery.js #64
Comments
it looks like the package.js needs to be updated to exclude rql in a similar way to how it excludes json-schema. @TomasNielsen if you want to try, i believe https://github.com/SitePen/dstore/blob/0e056138f5dbef577c6f2b78d0a2e39acb89b759/package.js#L32 is the place to focus your attention and have that function return true if rql is not in the packages and the filename is anything that depends on rql. it already does this for json-schema but not for rql (despite the comment) |
Could a solution be to add "rql/js-array.js" to dstore so it can be found? |
@TomasNielsen i believe it's intentionally not added since it's "optional" - i.e. if you don't use RqlQuery in your app then you don't need to install rql as a dependency. in my case, i use RqlQuery so i've used bower to install rql as part of my app ( fyi - i expect that there will likely be an update to dstore that will fix this issue for you. i'm just trying to give you options to move ahead until that happens. |
I see. Thanks for the suggestion! I'll await the nicer solution. It is a little pain to instruct all my team mates to manually delete a file to be able to build. |
My build fails on RqlQuery because on line 3 there is a dependency on a file 'rql/js-array' which is not present.
For my purposes I could get away with just deleting the RqlQuery.js file. But it seems like arrayEngine is used in some cases.
The text was updated successfully, but these errors were encountered: