Memory store putSync performance improvement #227
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #183
The existing logic splices out a modified element and splices it back in
any time an update is made with
putSync
. With large arrays the performanceof
Array#splice
is bad. Additionally, the store's index is rebuilt to accountfor moved items.
This PR adds a check to see if the item being put has moved. If not, the array
is modified in-place with no splicing, and the store's index is not rebuilt.
Some boundary tests for
putSync
are also added to the test suite.Thanks to @nijuyr for the troubleshooting and approach.