Fix: Rendering for multiple nested head and body nodes
#812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agubler
added
bug
agubler
changed the title
head and body nodeshead and body nodes
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1454486:
|
Codecov Report
@@ Coverage Diff @@
## master #812 +/- ##
=======================================
Coverage 97.53% 97.53%
=======================================
Files 127 127
Lines 7959 7962 +3
Branches 1835 1836 +1
=======================================
+ Hits 7763 7766 +3
Misses 196 196
Continue to review full report at Codecov.
|
tomdye
approved these changes
Jul 15, 2020
matt-gadd
approved these changes
Jul 21, 2020
agubler
added a commit
to agubler/framework
that referenced
this pull request
Jul 22, 2020
agubler
added a commit
that referenced
this pull request
Jul 22, 2020
* Fix types for insert after/before (#802) Change insertBefore/After to allow any template children rather than typing based on the targeted node. * Fix: Rendering for multiple nested `head` and `body` nodes (#812) * failing unit test for nested body and head tags * skip head or body node when finding insert before node * move JSX types to tsx namespace (#818) * fix unit test that was missed on master Co-authored-by: Bradley Maier <bmaier@sitepen.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: bug
The following has been addressed in the PR:
prettieras per the readme code style guidelinesDescription:
Ensure that
headandbodynodes are not used as insert before candidates.Resolves #809