Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update insertSiblings type definition #872

Merged
merged 2 commits into from
Jan 22, 2021

Conversation

samends
Copy link
Contributor

@samends samends commented Dec 8, 2020

Type: Bug

The following has been addressed in the PR:

Description:

Resolves #870
Updates type definitions for insertSiblings function

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 8, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 44e0ce9:

Sandbox Source
dojo/dojo-codesandbox-template Configuration

@codecov
Copy link

codecov bot commented Dec 8, 2020

Codecov Report

Merging #872 (44e0ce9) into master (9bbcff9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #872   +/-   ##
=======================================
  Coverage   94.72%   94.72%           
=======================================
  Files         127      127           
  Lines        8130     8130           
  Branches     1894     1894           
=======================================
  Hits         7701     7701           
  Misses        429      429           
Impacted Files Coverage Δ
src/testing/renderer.ts 97.32% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da85f2e...44e0ce9. Read the comment docs.

@samends samends changed the title Added overload insertSiblings definition Updated insertSiblings type definition Dec 8, 2020
@samends samends changed the title Updated insertSiblings type definition Update insertSiblings type definition Dec 8, 2020
@agubler
Copy link
Member

agubler commented Dec 9, 2020

@samends I think we can add a test that uses this API with a function based widget - without your changes it should fail with compilation errors and after should work?

@samends
Copy link
Contributor Author

samends commented Dec 9, 2020

Make sense, I'll add that in

@samends samends merged commit 25b80c5 into dojo:master Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

insertSiblings not overloaded
2 participants