Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resources: Fix getting for an unknown id #884

Merged
merged 3 commits into from
Mar 9, 2021

Conversation

agubler
Copy link
Member

@agubler agubler commented Mar 9, 2021

Type: bug

The following has been addressed in the PR:

Description:

Fixes an error that occurs if get is used for an id that doesn't exist in the resource cache.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 9, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d2dd6d3:

Sandbox Source
dojo/dojo-codesandbox-template Configuration

@codecov
Copy link

codecov bot commented Mar 9, 2021

Codecov Report

Merging #884 (80a3392) into master (c3b4866) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #884   +/-   ##
=======================================
  Coverage   94.52%   94.52%           
=======================================
  Files         127      127           
  Lines        8094     8095    +1     
  Branches     1888     1889    +1     
=======================================
+ Hits         7651     7652    +1     
  Misses        443      443           
Impacted Files Coverage Δ
src/core/middleware/resources.ts 95.69% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3b4866...d2dd6d3. Read the comment docs.

@agubler agubler requested a review from matt-gadd March 9, 2021 11:55
@agubler agubler merged commit 2073a03 into dojo:master Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants