Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only run the inert middleware when the properties have been changed #888

Merged
merged 2 commits into from
Mar 16, 2021

Conversation

agubler
Copy link
Member

@agubler agubler commented Mar 16, 2021

Type: bug

The following has been addressed in the PR:

Description:

This only adds/removes the inert properties to the node when the options have changed when calling the middleware

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6eae475:

Sandbox Source
dojo/dojo-codesandbox-template Configuration

@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #888 (6eae475) into master (ad9f5e4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #888   +/-   ##
=======================================
  Coverage   94.53%   94.54%           
=======================================
  Files         127      127           
  Lines        8113     8119    +6     
  Branches     1894     1895    +1     
=======================================
+ Hits         7670     7676    +6     
  Misses        443      443           
Impacted Files Coverage Δ
src/core/middleware/inert.ts 97.50% <100.00%> (+0.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad9f5e4...6eae475. Read the comment docs.

@agubler agubler merged commit f4e0d79 into dojo:master Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants