This repository has been archived by the owner on Jul 30, 2018. It is now read-only.
Implement locale message caching. #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cache locale-specific message dictionaries after they have been loaded, returning those cached objects on subsequent calls to `i18n`. Also add a `getCachedMessages` function that returns caches locale dictionaries synchronously, with an additional `invalidate` function for clearing bundle caches. Finally, after a locale dictionary has been resolved, freeze it so it cannot be modified.
mwistrand
commented
Oct 16, 2016
| const cached = bundleMap[bundlePath]; | ||
|
|
||
| if (cached) { | ||
| return cached[locale] as T; |
There was a problem hiding this comment.
Without the as T, the TS compiler warns that Messages cannot be assigned to type void | T; hence the casting.
Current coverage is 99.24% (diff: 100%)@@ master #20 diff @@
==========================================
Files 2 2
Lines 111 133 +22
Methods 1 1
Messages 0 0
Branches 22 26 +4
==========================================
+ Hits 110 132 +22
Misses 1 1
Partials 0 0
|
Within `getCachedMessages`, use the bundle's supported `locales` to determine whether the default messages should be returned, and to normalize the locale to the most specific supported locale.
kitsonk
reviewed
Oct 18, 2016
| @@ -90,6 +90,7 @@ export interface Messages { | |||
| const PATH_SEPARATOR: string = has('host-node') ? global.require('path').sep : '/'; | |||
| const VALID_PATH_PATTERN = new RegExp(PATH_SEPARATOR + '[^' + PATH_SEPARATOR + ']+$'); | |||
| const contextObjects: LocaleContext<LocaleState>[] = []; | |||
| let bundleMap = {} as BundleMap<Messages>; | |||
There was a problem hiding this comment.
Would it be better to use a Map here?
There was a problem hiding this comment.
Or at least a Object.create(null)?
There was a problem hiding this comment.
A Map would be more elegant here.
| let localeCache = bundleMap[bundlePath]; | ||
|
|
||
| if (!localeCache) { | ||
| localeCache = bundleMap[bundlePath] = {}; |
There was a problem hiding this comment.
Again, maybe Object.create(null)?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #19. As noted in the issue, the purpose for this PR is to facilitate incorporation into
dojo-widgets.