This repository has been archived by the owner on Jul 30, 2018. It is now read-only.
Implementing Observables shim, issue #59 #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, I should note.. I talked with @matt-gadd about the fact that our interface calls a property |
Current coverage is 97.04% (diff: 100%)@@ master #62 diff @@
==========================================
Files 29 30 +1
Lines 1129 1287 +158
Methods 23 24 +1
Messages 0 0
Branches 211 248 +37
==========================================
+ Hits 1091 1249 +158
Misses 21 21
Partials 17 17
|
|
OK don't review this just yet.. I ran against the tests that Ant mentioned and I've got some things to fix up first :) |
|
OK. Refactored quite a bit... All the ES spec tests pass now! |
|
A couple of notes, The ES spec tests have some pretty specific requirements about properties being non-enumerable, and certain object prototypes being I was wondering if you guys knew of an approach where I could use a static prototype, but still have certain internal variables ( |
Current coverage is 97.04% (diff: 100%)@@ master #62 diff @@
==========================================
Files 29 30 +1
Lines 1129 1285 +156
Methods 23 24 +1
Messages 0 0
Branches 211 248 +37
==========================================
+ Hits 1091 1247 +156
Misses 21 21
Partials 17 17
|
agubler
suggested changes
Dec 7, 2016
| */ | ||
| function startSubscription<T>(executor: Subscriber<T>, observer: Observer<T>): Subscription { | ||
| let closed = false; | ||
| let cleanUp: any; |
There was a problem hiding this comment.
I think we can type cleanUp to the union type return of the executor.
There was a problem hiding this comment.
So cleanUp is either undefined or a method with no parameters and no return value, so I've typed it as such (not just the return value of executor).
| else if (result && 'unsubscribe' in result) { | ||
| cleanUp = result.unsubscribe; | ||
| } | ||
| else if (result !== undefined && result !== null) { |
There was a problem hiding this comment.
Unfortunately not.. if the return value is undefined or null, no error. But if the return value is the number 0 or false, we want to error.
| } else { | ||
| throw new TypeError('Observer.complete is not a function'); | ||
| } | ||
| } else if (cleanUpError) { |
agubler
approved these changes
Dec 7, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
Description:
Shim implementation of ES observables spec. Non-spec functionality (i.e.,
toPromise,map,filter) will go in core.Related Issue: #59
Please review this checklist before submitting your PR: