This repository has been archived by the owner on Jul 30, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This looks really good, just needs some updates for the REAME and I think it's good to go. |
75248c7
to
94c35c9
Compare
agubler
approved these changes
Feb 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
prettier
as per the readme code style guidelinesDescription:
Refactors the undo manager to be a more a generic history manager. This mvp currently allows serialization and deserialization of an entire history, as well as undo'ing and redo'ing.
I made a few breaking changes:
id
when creating a process. this is so we can trace the middleware/callbacks used for each process and re-apply them when we deserialize. Having to provide anid
is a little annoying, but in the long run it will also help us for tracing other things (like in the dev tools).ProcessOptions
, in favour of just providing the callback. In a subsequent PR we should renamecallback
tomiddleware
. If we ever do need options on a Process, they would be separate from the middleware anyway.ProcessResult
, this is because it's difficult to sync changes with the history manager (the undo manager used to overwrite the undoer function, which we could do again but it is ugly). we do provideundoOperations
and thestore
on theProcessResult
now though, so if you do not care about the history manager you can manually apply theundoOperations
to get the same effect.I need to fix up some of the loose typings, some missing tests and update the README.
Resolves #???