CLDR webpack loader and plugin #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #243 +/- ##
==========================================
+ Coverage 84.25% 84.26% +<.01%
==========================================
Files 46 48 +2
Lines 2096 2186 +90
Branches 564 579 +15
==========================================
+ Hits 1766 1842 +76
- Misses 330 344 +14
Continue to review full report at Codecov.
|
mwistrand
approved these changes
Jan 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
prettieras per the readme code style guidelinesDescription:
Adds a loader and plugin that together enable Dojo application's to automatically detect required CLDR data based on a set of locales. The Plugin detects if any of the dojo framework i18n formatter modules are used in the application and creates appropriate CLDR bundles for all supported locales. The loader generates the CLDR data loaders that are set on the applications i18n API so that they can be used to lazily load the CLDR data on request.
For
syncmode (i.e. single-bundle), all the i18n CLDR data is included in the main bundle.Related to dojo/framework#655
Note: requires release of dojo/framework