Update to @dojo/framework and bump to 3.0 #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #55 +/- ##
==========================================
+ Coverage 96.55% 98.86% +2.31%
==========================================
Files 19 19
Lines 551 616 +65
Branches 134 162 +28
==========================================
+ Hits 532 609 +77
Misses 7 7
+ Partials 12 0 -12
Continue to review full report at Codecov.
|
agubler
reviewed
Jul 18, 2018
package.json
Outdated
| "prettier": "prettier --write 'src/**/*.ts' 'tests/**/*.ts'", | ||
| "test": "grunt test" | ||
| }, | ||
| "peerDependencies": { | ||
| "@dojo/framework": "file:./tarballs/dojo-framework-3.0.0-pre.tgz" |
There was a problem hiding this comment.
It's only a peer dependency for the time being so this can be made into a tarball and installed itself.
bryanforbes
force-pushed
the
3.0.0
branch
7 times, most recently
from
a3dc5e0 to
46470c0
Compare
agubler
approved these changes
Jul 20, 2018
bryanforbes
force-pushed
the
3.0.0
branch
2 times, most recently
from
d069e55 to
5a127fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
prettieras per the readme code style guidelinesDescription:
Resolves #54