Bootstrap Plugin #99
Merged
Bootstrap Plugin #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agubler
commented
Dec 3, 2018
| @@ -8,6 +8,6 @@ if (!has.exists('build-time-render')) { | |||
|
|
|||
| if (globals.default.__public_path__) { | |||
| // @ts-ignore | |||
| __webpack_public_path__ = `${window.location.origin}${globals.default.__public_path__}`; | |||
| __webpack_public_path__ = window.location.origin + globals.default.__public_path__; | |||
Codecov Report
@@ Coverage Diff @@
## master #99 +/- ##
==========================================
- Coverage 85.49% 84.73% -0.76%
==========================================
Files 33 35 +2
Lines 1275 1336 +61
Branches 356 364 +8
==========================================
+ Hits 1090 1132 +42
- Misses 185 204 +19
Continue to review full report at Codecov.
|
matt-gadd
approved these changes
Dec 7, 2018
matt-gadd
approved these changes
Dec 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
prettieras per the readme code style guidelinesDescription:
Description:
Adds
BootstrapPluginthat provides abootstrap.jsfile to be used as an application entry point. Thebootstrap.jsperforms runtime checks to determine if shims from@dojo/frameworkneed to be loaded. Thebootstrap.jswill only load shims that are being used within the application.Related to dojo/framework#183