-
Notifications
You must be signed in to change notification settings - Fork 39
Consider applying core mixins to WidgetBase by default #581
Comments
I would be 👍 for I think with |
@agubler is this still valid (undone)? I don't think it is a discussion anymore because we all think it is a 👍. If still to do, will it make beta4, or should we move it to beta5? |
@kitsonk perhaps with the changes coming to |
@agubler any further action on this? It feels that with other changes we have largely mitigated this issue? |
Completely mitigated in my opinion, closing. |
Enhancement
The main core mixins,
Themeable
,I18n
andRegistry
provide functionality that could be automatically mixed in toWidgetBase
by default. This would remove possible friction for consumer to need to deal with the mixin concept early on in Dojo 2 adoption.The mixins are all additive functionality and shouldn't impact consumers who only need core
WidgetBase
functionality.This would leave:
Stateful
, which I think we should consider removing in favour of promoting use of typed class properties for any required internal state.Projector
, which would remain as an optional mixin to decorate a widget with functionality required to attach to the DOM.The text was updated successfully, but these errors were encountered: