This repository has been archived by the owner on Jul 30, 2018. It is now read-only.
Fix behavior for multiple nodes with the same root in intersection meta #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-gadd
reviewed
Nov 8, 2017
src/meta/Intersection.ts
Outdated
| if (!details) { | ||
| details = this._createDetails(options, rootNode); | ||
| if (!details || !details.entries.get(node)) { | ||
| if (!details) { |
There was a problem hiding this comment.
am i missing a subtlety here? (presuming if there isn't any details that there won't be an entry?), could the code not just be:
details = details || this._createDetails(options, rootNode)
if (!details.entries.get(node)) {
details.entries.set(node, defaultIntersection);
details.observer.observe(node);
}There was a problem hiding this comment.
Yeah no reason not to simplify it that way. Code's been updated
matt-gadd
approved these changes
Nov 8, 2017
maier49
force-pushed
the
727-intersection-meta
branch
from
e6dedc1
to
76514c4
Compare
maier49
force-pushed
the
727-intersection-meta
branch
from
76514c4
to
23fdc0e
Compare
kitsonk
approved these changes
Nov 8, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: bug
The following has been addressed in the PR:
Description:
The intersection meta would not observe any nodes after the first called for a given
options+rootcombination. This updates the logic so thatdetailsis only created once for eachoptions+rootcombination but each new node requested is observed. A default value for details is provided for each node to avoid observing that node more than once.Resolves #727