Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themed icon classes missing from built components #295

Closed
bitpshr opened this issue Sep 6, 2017 · 1 comment
Closed

Themed icon classes missing from built components #295

bitpshr opened this issue Sep 6, 2017 · 1 comment
Assignees
Milestone

Comments

@bitpshr
Copy link
Member

bitpshr commented Sep 6, 2017

Bug

When using production-built components that use icon CSS classes, like Select, ComboBox, or TimePicker, the icon classes are applied incorrectly.

Package Version: latest

Code

  1. dojo create app --name test-app
  2. cd test-app && npm install --save-dev @dojo/widgets
  3. Import and use Select, ComboBox, or TimePicker inside widgets/HelloWorld
  4. Notice down arrow style errors

Expected behavior:

screen shot 2017-09-06 at 11 24 21 am

Actual behavior:

screen shot 2017-09-06 at 11 23 26 am

@bitpshr bitpshr mentioned this issue Sep 6, 2017
3 tasks
@dylans dylans added this to the 2017.09 milestone Sep 7, 2017
@eheasley eheasley added beta4 and removed beta3 labels Oct 3, 2017
@eheasley eheasley modified the milestones: 2017.09, 2017.10 Oct 6, 2017
@tomdye tomdye self-assigned this Oct 26, 2017
@kitsonk kitsonk modified the milestones: 2017.10, beta.4 Oct 30, 2017
@tomdye
Copy link
Member

tomdye commented Nov 1, 2017

This has been fixed via a change to version 0.1.1 of cli-build-webpack, cli-create-app should be updated accordingly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants