Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix select styling inconsistency and fix icon issues #350

Merged
merged 4 commits into from
Nov 7, 2017

Conversation

tomdye
Copy link
Member

@tomdye tomdye commented Nov 1, 2017

Type: bug

The following has been addressed in the PR:

  • There is a related issue
  • All code matches the style guide
  • Unit or Functional tests are included in the PR

Description:

Fixes a styling inconsistency in Select.
Fixes missing icons / drop down styles

#295 #299

@codecov
Copy link

codecov bot commented Nov 1, 2017

Codecov Report

Merging #350 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #350   +/-   ##
=======================================
  Coverage   98.84%   98.84%           
=======================================
  Files          23       23           
  Lines        1901     1901           
  Branches      488      488           
=======================================
  Hits         1879     1879           
  Partials       22       22

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18e4fce...74f88c9. Read the comment docs.

Copy link
Contributor

@smhigley smhigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and simple

@tomdye tomdye changed the title 295 icon Fix select styling inconsistency Nov 7, 2017
@tomdye tomdye changed the title Fix select styling inconsistency Fix select styling inconsistency and fix icon issues Nov 7, 2017
@tomdye tomdye merged commit dbf402f into dojo:master Nov 7, 2017
@dylans dylans added this to the beta.4 milestone Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants