New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert themes to new variant format #1134

Closed

tomdye wants to merge 2 commits into dojo:master from tomdye:theme-variants

Member

tomdye commented Mar 11, 2020

Type: Feature

The following has been addressed in the PR:

There is a related issue
All code matches the style guide
Unit tests are included in the PR
For new widgets, an entry has been added to the .dojorc
Any widget variant uses theme.compose like this
WidgetProperties are exported

Description:

This PR:

removes variable imports
creates default theme variants
exports themes in new variant format

Requires framework and build changes to be merged first.

Work towards: dojo/framework#683

tomdye added 2 commits

March 11, 2020 17:01


          move themes to variant format

2f7204c


          add variant class calls to root renders

52b93a6

tomdye closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet