Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1612 - Select rejects bad values #1720

Merged
merged 2 commits into from
Apr 8, 2021

Conversation

KaneFreeman
Copy link
Member

Type: bug

The following has been addressed in the PR:

  • There is a related issue
  • All code matches the style guide
  • Unit tests are included in the PR
  • For new widgets, an entry has been added to the .dojorc
  • For new widgets, theme.variant() is added to the root domnode
  • Any widget variant uses theme.compose like this
  • WidgetProperties are exported

Description:

  • If no item can be queried from the resource with the given value:
    • Select will no longer display value
    • Select will style itself as it empty
  • Returned query results will be checked against the given value to ensure it matches

Resolves #1612

@vercel
Copy link

vercel bot commented Apr 7, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

widget-test-docs – ./

🔍 Inspect: https://vercel.com/dojo/widget-test-docs/38gMmYPXfxpd4oSEZvDuMaKg9KCs
✅ Preview: https://widget-test-do-git-fork-kanefreeman-bugfix-select-value-b27900.vercel.app

dojo.widgets – ./

🔍 Inspect: https://vercel.com/dojo/dojo.widgets/8jueZBYQjtHHRJyp1o1rJ1SbwDoZ
✅ Preview: https://dojowidgets-git-fork-kanefreeman-bugfix-select-value-set-dojo1.vercel.app

@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #1720 (f4ad933) into master (afc67b0) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1720      +/-   ##
==========================================
+ Coverage   90.17%   90.21%   +0.04%     
==========================================
  Files          94       94              
  Lines        5088     5089       +1     
  Branches     1384     1385       +1     
==========================================
+ Hits         4588     4591       +3     
+ Misses        247      246       -1     
+ Partials      253      252       -1     
Impacted Files Coverage Δ
src/select/index.tsx 88.79% <100.00%> (+1.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afc67b0...f4ad933. Read the comment docs.

@KaneFreeman KaneFreeman merged commit 83c9dc6 into dojo:master Apr 8, 2021
@KaneFreeman KaneFreeman deleted the bugfix/select-value-set branch April 8, 2021 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An incorrect value can be set on the select
2 participants