Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1734 - Pass date input's required flag down to child text input #1741

Merged

Conversation

KaneFreeman
Copy link
Member

Type: bug

The following has been addressed in the PR:

  • There is a related issue
  • All code matches the style guide
  • Unit tests are included in the PR
  • For new widgets, an entry has been added to the .dojorc
  • For new widgets, theme.variant() is added to the root domnode
  • Any widget variant uses theme.compose like this
  • WidgetProperties are exported

Description:
Pass date input's required flag down to child text input

Resolves #1734

@vercel
Copy link

vercel bot commented Apr 12, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

dojo.widgets – ./

🔍 Inspect: https://vercel.com/dojo/dojo.widgets/GFmuQCh5tu18vj99gzXLjps9mLD4
✅ Preview: https://dojowidgets-git-fork-kanefreeman-bugfix-1734-date-pic-e4d2a5.vercel.app

widget-test-docs – ./

🔍 Inspect: https://vercel.com/dojo/widget-test-docs/BtL9nTpP2FzNKx9SgEB6kaRyjvs5
✅ Preview: https://widget-test-do-git-fork-kanefreeman-bugfix-1734-date-pic-d4cfba.vercel.app

@codecov
Copy link

codecov bot commented Apr 12, 2021

Codecov Report

Merging #1741 (144457c) into master (ad3829b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1741   +/-   ##
=======================================
  Coverage   90.24%   90.24%           
=======================================
  Files          94       94           
  Lines        5116     5116           
  Branches     1392     1392           
=======================================
  Hits         4617     4617           
  Misses        244      244           
  Partials      255      255           
Impacted Files Coverage Δ
src/date-input/index.tsx 91.37% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad3829b...144457c. Read the comment docs.

@KaneFreeman KaneFreeman merged commit 5fcaf00 into dojo:master Apr 13, 2021
@KaneFreeman KaneFreeman deleted the bugfix/1734-date-picker-required-asterisk branch April 13, 2021 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Required date input does not have a * appended to the label
2 participants