Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1730 - Fix width of list item's primary span to expand to fill parent #1743

Merged

Conversation

KaneFreeman
Copy link
Member

@KaneFreeman KaneFreeman commented Apr 12, 2021

Type: bug

The following has been addressed in the PR:

  • There is a related issue
  • All code matches the style guide
  • Unit tests are included in the PR
  • For new widgets, an entry has been added to the .dojorc
  • For new widgets, theme.variant() is added to the root domnode
  • Any widget variant uses theme.compose like this
  • WidgetProperties are exported

Description:
Fix width of list item's primary span to expand to fill parent, so loading indicators appear correctly.

image

Resolves #1730

@vercel
Copy link

vercel bot commented Apr 12, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

dojo.widgets – ./

🔍 Inspect: https://vercel.com/dojo/dojo.widgets/5mKtCCFYTy6Bb7B9nBSfi9d76AoQ
✅ Preview: https://dojowidgets-git-fork-kanefreeman-bugfix-1730-list-loa-f7f36c.vercel.app

widget-test-docs – ./

🔍 Inspect: https://vercel.com/dojo/widget-test-docs/HKcN7QXp7v1uA39vaPuQ6t8XeQUJ
✅ Preview: https://widget-test-do-git-fork-kanefreeman-bugfix-1730-list-loa-187f81.vercel.app

@codecov
Copy link

codecov bot commented Apr 12, 2021

Codecov Report

Merging #1743 (f0ba362) into master (3ef7917) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1743   +/-   ##
=======================================
  Coverage   90.24%   90.24%           
=======================================
  Files          94       94           
  Lines        5116     5116           
  Branches     1392     1392           
=======================================
  Hits         4617     4617           
  Misses        244      244           
  Partials      255      255           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ef7917...f0ba362. Read the comment docs.

@KaneFreeman KaneFreeman changed the title Fix width of list item's primary span to expand to fill parent 1730 - Fix width of list item's primary span to expand to fill parent Apr 12, 2021
Copy link
Member

@agubler agubler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, all the examples seem to work still 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The list no longer shows a loading indicator
2 participants