-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: easier list item theming #1744
Conversation
This pull request is being automatically deployed with Vercel (learn more). dojo.widgets – ./🔍 Inspect: https://vercel.com/dojo/dojo.widgets/8EU68kT3GV6vnsdDo4qTPxe1XJ2i widget-test-docs – ./🔍 Inspect: https://vercel.com/dojo/widget-test-docs/HtovuDZQT3JFKDkgcjjNLdQskmeB |
Codecov Report
@@ Coverage Diff @@
## master #1744 +/- ##
=======================================
Coverage 90.24% 90.24%
=======================================
Files 94 94
Lines 5116 5116
Branches 1392 1392
=======================================
Hits 4617 4617
Misses 244 244
Partials 255 255 Continue to review full report at Codecov.
|
What do you think to adding an example? We should be able to demonstrate this by rendering a list with the I think you can define them inline over the class, which will be super clear in the example of what is going on. |
Sorry @bitpshr forgot to mention you in the comment above ^ |
8536de2
to
37918c4
Compare
Type: feature
The following has been addressed in the PR:
.dojorc
theme.variant()
is added to the root domnodetheme.compose
like thisDescription:
This pull request updates the
ListItem
by adding background and color variables to applicable states (disabled, active, selected) so that it can be themed independently of other widgets.Resolves #1726