Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: easier list item theming #1744

Merged
merged 3 commits into from
Apr 15, 2021
Merged

feat: easier list item theming #1744

merged 3 commits into from
Apr 15, 2021

Conversation

bitpshr
Copy link
Member

@bitpshr bitpshr commented Apr 13, 2021

Type: feature

The following has been addressed in the PR:

  • There is a related issue
  • All code matches the style guide
  • Unit tests are included in the PR
  • For new widgets, an entry has been added to the .dojorc
  • For new widgets, theme.variant() is added to the root domnode
  • Any widget variant uses theme.compose like this
  • WidgetProperties are exported

Description:

This pull request updates the ListItem by adding background and color variables to applicable states (disabled, active, selected) so that it can be themed independently of other widgets.

Resolves #1726

@vercel
Copy link

vercel bot commented Apr 13, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

dojo.widgets – ./

🔍 Inspect: https://vercel.com/dojo/dojo.widgets/8EU68kT3GV6vnsdDo4qTPxe1XJ2i
✅ Preview: https://dojowidgets-git-feat-list-item-theming-dojo1.vercel.app

widget-test-docs – ./

🔍 Inspect: https://vercel.com/dojo/widget-test-docs/HtovuDZQT3JFKDkgcjjNLdQskmeB
✅ Preview: https://widget-test-docs-git-feat-list-item-theming-dojo1.vercel.app

@codecov
Copy link

codecov bot commented Apr 13, 2021

Codecov Report

Merging #1744 (d7658b6) into master (4b0ce16) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1744   +/-   ##
=======================================
  Coverage   90.24%   90.24%           
=======================================
  Files          94       94           
  Lines        5116     5116           
  Branches     1392     1392           
=======================================
  Hits         4617     4617           
  Misses        244      244           
  Partials      255      255           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b0ce16...d7658b6. Read the comment docs.

@agubler
Copy link
Member

agubler commented Apr 14, 2021

What do you think to adding an example? We should be able to demonstrate this by rendering a list with the variant="inherit" property in a wrapping node that has a class that changes the definition of the new variables 😄

I think you can define them inline over the class, which will be super clear in the example of what is going on.

@agubler
Copy link
Member

agubler commented Apr 14, 2021

Sorry @bitpshr forgot to mention you in the comment above ^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CSS Variables to be able to control specific list styles
2 participants